Rework cache to use inline cache #586
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
commented
May 30, 2024
| @@ -80,65 +110,56 @@ session-dependent objects (e.g., a `CuModule`). | |||
| function cached_compilation(cache::AbstractDict{<:Any,V}, | |||
There was a problem hiding this comment.
This would be the API breakage. We need to change this to AbstractDict{<:Any, CacheEntry}{V}} or take V as a separate parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently put entries into the cache under two different keys.
The first is meant as a fast hit in scenarios where the current world-age is not changing.
If we follow Julia Base, we could instead replace the first with a linear search over a small
number of entries.
By storing the ci as a field in the cache struct we quickly check if the cache is still valid,
currently when the
tls_worldchanges we fall-back to the slower cache check.I was thinking of adding something similar to Enzyme.
This is an API breakage though. So I am not convinced it is worth it right now.